Skip to content

chore: remove @[simp] from forall_const#5309

Closed
kim-em wants to merge 1 commit intomasterfrom
unsimp_forall_const
Closed

chore: remove @[simp] from forall_const#5309
kim-em wants to merge 1 commit intomasterfrom
unsimp_forall_const

Conversation

@kim-em
Copy link
Copy Markdown
Collaborator

@kim-em kim-em commented Sep 11, 2024

No description provided.

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 11, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 11, 2024 08:35 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 11, 2024
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Sep 11, 2024
Update lean-toolchain for testing leanprover/lean4#5309
3cc1136
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 11, 2024
Update lean-toolchain for testing leanprover/lean4#5309
49e0a86
@ghost ghost added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 11, 2024
@ghost
Copy link
Copy Markdown

ghost commented Sep 11, 2024

Mathlib CI status (docs):

@ghost
Copy link
Copy Markdown

ghost commented Sep 11, 2024

Mathlib CI status (docs):

@kim-em kim-em force-pushed the unsimp_forall_const branch from c7e5280 to 872a885 Compare September 12, 2024 01:13
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
fixes for leanprover/lean4#5309
dc7c7e8
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
fixes for leanprover/lean4#5309
8ec1a25
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 12, 2024 01:49 Inactive
ghost pushed a commit to leanprover-community/batteries that referenced this pull request Sep 12, 2024
Trigger CI for leanprover/lean4#5309
43de354
ghost pushed a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
Trigger CI for leanprover/lean4#5309
8f43a4f
@ghost
Copy link
Copy Markdown

ghost commented Sep 12, 2024

Mathlib CI status (docs):

@ghost
Copy link
Copy Markdown

ghost commented Sep 12, 2024

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 12, 2024
@kim-em
bump batteries for leanprover/lean4#5309
24c6a42
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 12, 2024
@ghost ghost added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 12, 2024
@ghost
Copy link
Copy Markdown

ghost commented Sep 12, 2024

Mathlib CI status (docs):

@kim-em
Copy link
Copy Markdown
Collaborator Author

kim-em commented Sep 16, 2024

This doesn't give much performance improvement over Mathlib, so is a bad idea.

@kim-em kim-em closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kim-em